Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): share juror score on x #1297

Merged
merged 6 commits into from
Oct 30, 2023
Merged

feat(web): share juror score on x #1297

merged 6 commits into from
Oct 30, 2023

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented Oct 24, 2023 •
edited by pr-codex bot
Loading

Special mention and thanks to @ptdatta for starting this effort

Can't continue until #1290 is merged

PR-Codex overview

Focus of the PR:

This PR focuses on adding a new component called Header to the JurorInfo page in the Dashboard. The Header component displays the juror's level title, level number, total coherence, and total resolved disputes. It also includes a link to share the juror's score on Twitter.

Detailed summary:

  • Added a new component called Header to the JurorInfo page.
  • Imported Header component in the JurorInfo page.
  • Added styles and layout for the Header component.
  • Passed necessary props to the Header component.
  • Added a link to share the juror's score on Twitter in the Header component.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@netlify
Copy link

netlify bot commented Oct 24, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 79fa3ea
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/653ff9f8c976a70008fc0c7b
😎 Deploy Preview https://deploy-preview-1297--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kemuru kemuru mentioned this pull request Oct 24, 2023
Closed
@kemuru kemuru linked an issue Oct 24, 2023 that may be closed by this pull request
Gamification: buttons to let the user share their score on social media #1061
Closed
@developerkunal
Copy link

They want to convert that component into image and share it on twitter.

@kemuru
Copy link
Contributor Author

kemuru commented Oct 30, 2023

I have tried doing what @developerkunal suggested (attaching image of the component to the tweet). in fact, is what I had in mind at first.
However, after trying, the image took +20s to generate from the component, then also realized that Twitter has no easy way of attaching images in a preview tweet (like we do with text here).
So all in all, I decided it's better with just text, also faster to see. lmk what you think.

@kemuru kemuru marked this pull request as ready for review October 30, 2023 13:27
@kemuru kemuru requested a review from alcercu October 30, 2023 13:31
alcercu
alcercu approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu enabled auto-merge October 30, 2023 14:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 30, 2023

Code Climate has analyzed commit 79fa3ea and detected 0 issues on this pull request.

View more on Code Climate.

@alcercu alcercu added this pull request to the merge queue Oct 30, 2023
Merged via the queue into dev with commit 74235df Oct 30, 2023
11 checks passed
@jaybuidl jaybuidl added this to the testnet-2.1 milestone Oct 30, 2023
@jaybuidl jaybuidl deleted the feat(web)/x-share-juror-score branch December 12, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu approved these changes

Assignees
No one assigned
Labels
Package: Web Court web frontend Type: Feature🗿
Projects
None yet
Milestone
testnet-2.1
Development

Successfully merging this pull request may close these issues.

Gamification: buttons to let the user share their score on social media
4 participants
@kemuru @developerkunal @alcercu @jaybuidl